Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Mobile Code First QR Component

@GMuhaideb

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I found it difficult to push the code to github using VS code terminal I continuously faced "error: failed to push some refs to 'https://github.com/GMuhaideb/qr-code-component.git'". However, I upload it traditional way using drag and drop the files.

Community feedback

@asbhogal

Posted

Hi Ghadah,

This is great work, well done! I'd definitely look into the Git terminal issues as soon as you can to avoid any problems with workflows in future projects (unless this is a localized incident.)

  • You have a typo in your text - "bulding"
  • You're missing an alt attribute value, which is important for screen readers and other assistive technologies to be able to understand the purpose and context of the img
  • Your container should ideally be placed inside a <main> element for accessibility purposes as well - it helps direct users to the area of the most prominent content of the document body
  • Always locally host your Google Fonts for privacy and performance reasons. Here's a good video by Kevin Powell which goes through the process of doing this Link
  • You can replace the height with a min-height: 100vh to prevent any vertical overflow

Hope this helps!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord