Mobile Code First QR Component

Community feedback

• 

  Aman Singh Bhogal•1,010

  @asbhogalPosted over 1 year ago

  Hi Ghadah,

  This is great work, well done! I'd definitely look into the Git terminal issues as soon as you can to avoid any problems with workflows in future projects (unless this is a localized incident.)

  • You have a typo in your text - "bulding"
  • You're missing an alt attribute value, which is important for screen readers and other assistive technologies to be able to understand the purpose and context of the img
  • Your container should ideally be placed inside a <main> element for accessibility purposes as well - it helps direct users to the area of the most prominent content of the document body
  • Always locally host your Google Fonts for privacy and performance reasons. Here's a good video by Kevin Powell which goes through the process of doing this Link
  • You can replace the height with a min-height: 100vh to prevent any vertical overflow

  Hope this helps!

  Marked as helpful

  0