Mobile and Web page using HTML, CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 9 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Aizirek•140

  @nurlanova2012Posted 9 months ago

  Thanks a lot for your time and recommendations, Abdul Khalid. I will revise the code accordingly. @0xabdulkhalid

  0
• 

  Bishal Singh Deo🎮•1,440

  @Bishalsnghd07Posted 9 months ago

  Hi, @nurlanova2012 👋

  There is few adjustments needed in your code:

  1)Semantic ui error: I see your code, you did not follow the Heading level. It always should be like this 👉 h1, h2, h3, h4, h5 & h6. You use h3 after h1. It should not be like this, for maintain accessibility of your web page, you should be follows the heading levels one by one.

  2)CSS foundation error: You missing important property, which is needed to maintain your layout responsive in smaller screen also, you just have to add 👉 min-height:100vh; in your body of web page. I did not see it, what happens when you did not give min-height in your body, your layout size will be work as your given height to your components, like if you give your component size lesser than your browser screen size, than your component will not take the entire height of your screen. That's why it is always recommend to use min-height so by doing that your layout will not breaking and will take entire size of your screen. Also, It is best practice to use.

  Hope, this suggestion will help you!

  Other than that great job👏

  body

    margin: 0 auto;
    padding: 0 50px;
    font-family: Heebo, sans-serif;
    font-weight: 400;
    font-style: normal;
    font-size: 16px;
    color: #382b21;
    line-height: 24px;
    min-height: 100vh;(add this✅)```
  

  Marked as helpful

  0

  ---

  

  Aizirek•140

  @nurlanova2012Posted 9 months ago

  Thank you for time and widespread response! @Bishalsnghd07

  0