Design comparison
Solution retrospective
This is my 1st attempt at html and css. Please give me feedback. Go easy on me. Thank you
Community feedback
- @sirriahPosted over 3 years ago
Hello, I saw you code. I think that naming components like "img" etc. is not the best idea. Try to look at BEM naming. This is a small project, but in bigger designs you will get lost.
I think, that you can make the image from side to side with 'object-fit: cover' property.
The whole component should have the maximum width set on specific size. If you have large screen then the width is now set on 100% and it looks strange.
The border radius is better to set with px or rem units.
Happy coding 👍
0@balliets10Posted over 3 years ago@sirriah Thank you for the critiques, I will look into your suggestions.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord