Design comparison
Solution retrospective
I'm most proud of how I've advanced my technical skills, particularly in using Git, GitHub, Figma, FFmpeg, and the Firefox developer tools. This experience not only enhanced my technical skills but also strengthened my problem-solving abilities and teamwork. Moving forward, I plan to delve deeper into CSS, especially exploring grid layouts and animations, to create more modern solutions.
What challenges did you encounter, and how did you overcome them?I was having some issues with Figma, but activating the dev mode and installing the VS Code extension helped a lot.
What specific areas of your project would you like help with?I feel like my CSS code is too verbose. I would love some suggestions to make my code more concise.
Community feedback
- @0xabdulkhaliqPosted 6 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- Use
min-height: 100vh
forbody
instead ofheight: 100svh
. Setting theheight: 100svh
may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation
- For example; if we set
height: 100svh
then thebody
will have100svh
height no matter what. Even if the content spans more than100svh
of viewport.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@gdsimoesPosted 6 months ago@0xabdulkhalid That was great feedback! I didn't even think about testing the website in landscape.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord