Minimal QR code scanner

Community feedback

• 

  Olaniyi Ezekiel•7,580

  @Ezekiel225Posted 9 months ago

  Hello there 👋 @VISHALKANNAN070.

  Good job on completing the challenge !

  Your project looks really good!

  I have suggestions about your code that might interest you.

  📌 First: Use <main> to wrap the main content instead of <div>.

  Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

  📌Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally: 📌 Apply this to the body element (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex;  /* it works with grid too  */
      justify-content: center;
      align-items: center;
  }
  

  📌If you don't have the Figma design files, I recommend using a browser extension called Perfect Pixel.

  It allows you to compare your finished project with the design images that come along when you download the project and check the (almost exact) dimensions. It's very useful!

  I hope this suggestion is useful for future projects.

  Other than that, great job!

  Keep up the excellent work and continue to challenge yourself with new projects. Your progress is impressive, and each project is a step forward in your front-end development journey! 🚀🌟.

  Happy coding.

  1

  ---

  

  VISHALKANNAN070•130

  @VISHALKANNAN070Posted 9 months ago

  @Ezekiel225. THANK YOU SO MUCH FOR YOUR KIND REPLY. As a beginner I'm trying to do my best. I'll consider your suggestion in my next project. Have a nice day !!! . (my English is not up to the mark , don't consider it rude <3). Check out my another work too, suggestions are appreciated..

  0