Messiest CSS in the Universe - Product preview card component

Community feedback

• 

  Charles•430

  @charlesmiller0412Posted about 2 years ago

  Hey @weakiam! Great job on this!

  I'm not sure what editor you use, but in VS Code you can enable auto-indent to help with the misalignment in your stylesheet. Another great thing to look into is BEM (Block Element Modifier). This will give structure to your CSS and acts as an easy-to-understand naming convention. BEM also works really well with SCSS as you can simply continue writing your styles within the same initial block. Check out https://getbem.com/ for more info on the methodology.

  Another thing to remember on these challenges is you can use absolute positioning on the footer in order to keep the object's center.

  Marked as helpful

  1

  ---

  

  Wiktor•110

  @wiktor-rocksPosted about 2 years ago

  @charlesmiller0412 I never realized that there are methodologies for working with CSS. I will need to look into that.

  Also, your comment about absolute positioning will save me hours trying to satisfy my brain by trying to align my footer like I want it to. Thank you very much for the help.

  0

  

  Charles•430

  @charlesmiller0412Posted about 2 years ago

  @weakiam glad I could offer some insight!

  Stay well and happy coding!

  1
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @weakiam, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Wiktor•110

  @wiktor-rocksPosted about 2 years ago

  @correlucas Hi, thank you very much for the feedback. I will have to look into the picture tag. It's already in my notes. Thanks again.

  1