meet-landing-page using css from scratch

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hello there! 👋

  Congratulations on finishing this challenge! 🎉

  Good job on using the width and height attributes for the img elements! This way, the browser knows how much space the image requires before it can be fully loaded. As a result, it would optimize CLS (Cumulative Layout Shift).

  I notice that the HTML has two link tags for the stylesheet. But, the typography.css doesn't exist in the assets/styles/ folder. So, I would recommend uploading or pushing the necessary CSS file for the site.

  Regarding the image, are you talking about the image-hero? For the image-hero, I made those as background images on all screen sizes.

  Some more suggestions for improvements.

  • Write your code with a consistent style (e.g. the indentation, quotes, whitespace, etc) or use code-formatter (e.g. Prettier). If you write or format your code that way, it will make it easier to read for everyone (including your future self).
  • The download button should be an anchor tag with download attribute (not a button).
  • I would recommend making the number between sections ( <aside>01</aside>) with pseudo-elements. It is possible to create those with pure CSS. As a result, it will clean up the HTML from the decorative elements.

  That's it! I hope this helps! 🙂

  1

  ---

  

  Christ Kevin Touga Watat•270

  @Christ-KevinPosted about 2 years ago

  @vanzasetia Thankyou so much

  1