Meet Landing Page using CSS grid templates

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey @peninoule, great job on this project!

  Some suggestions to improve you code:

  • For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

  • When using buttons/links alongside the “hover” effect, you’ll run into the problem where the hover effect gets “stuck”. To prevent this, you’ll want to add the @media (hover: hover) to your CSS code and include within the query all the classes that are using the hover effect. Since not all devices support hover effects this query will then check to see if it is or not.

  Happy Coding!

  Marked as helpful

  1

  ---

  

  peninoule•80

  @peninoulePosted about 2 years ago

  Hey @vcarames thanks a lot for the feedback, I'm definitely gonna take that into account from now on :D

  0