Design comparison
Solution retrospective
Loading different background-image
based on screen size, I used media queries to load each one using src()
.
Overall code feedback is appreciated.
Community feedback
- @jaceleedevPosted 4 months ago
Hello! Great job tackling this challenge. You've put in a lot of effort, and it shows in your work.
Regarding the HTML structure, I have a couple of suggestions to enhance the semantic meaning of your code:
-
Consider using 'section' tags to better organize your content. For example, you could wrap the hero content and the image grid. This will give more structure to your document.
-
It would be beneficial to add 'header' and 'footer' tags. The logo at the top could be wrapped in a 'header', and the final CTA section at the bottom could be placed within a 'footer'.
These changes will not only make your HTML more semantic but also improve accessibility and potentially boost SEO.
Keep up the great work, and happy coding!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord