Design comparison
Solution retrospective
Hi friends,
I've completed this challenge as fully responsive (mobile, tablet & desktop). This challenge is important to me, I will use it in my portfolio because of that can you give feedback about it? I learned so many things with feedback. Please let me know if you see any better way to implement the related code. Thank you in advance.
Community feedback
- Account deleted
Hello there! 👋
Congratulations on finishing your challenge! 🎉
I have some feedback on this solution:
- Always Use Semantic HTML instead of
div
like<main>
<header>
, etc for more info
if my solution has helped you do not forget to mark this as helpful!
Marked as helpful0 - Always Use Semantic HTML instead of
- @jrmydixPosted almost 3 years ago
Hi!
First of all, well done!
If this can help, I have some suggestions:
- Fix accessibility issues: use
main
,header
andfooter
tags to separate and identify your html code. - Footer background: try using the css property background on your
footer
instead of using 3img
tags - Active states: add hover properties to the buttons, for example the ones on the Figma design
- .page2-stick-img: Fix the position on mobile view and try the do it with html and css properties
If you have any questions feel free to ask, I'll try my best to help and answer! 🙂
0 - Fix accessibility issues: use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord