Design comparison
Solution retrospective
Hello Everyone! 👋
I finished my first premium challenge! 🎉
The most challenging part was the number elements between sections. However, I managed to handle them with only pseudo-elements. That way, I didn't have to deal with the accessibility thing (hopefully). 😅
Now for the questions:
- I put the logo in a
header
. I'm not sure that it is correct or not, so what do you think about it? Should I put the logo inside themain
element instead? - If you try using a screen reader on my website, can you understand the page content?
- Can you navigate this website comfortably using your keyboard?
Any questions on the technique that I'm using are welcome! 😁
Also, if you have finished this challenge and would like me to give feedback on it, please include a link to your solution. I would be glad to help you! 😀
Thanks!
Community feedback
- @FluffyKasPosted almost 3 years ago
Hiyo,
It looks great! I would've put the logo in the header too, that seems fine. According to the definition of
header
element on MDN, W3Schools, etc it's probably the correct way to do it. The rest of the page is very neat work too, love the added skip navigation button! :3The only teeny tiny "issue" I found is the colour of the pseudo-element numbers. It's not really an issue, just different from the design. :D But that's really all I could find.
Your documentation is awesome too, today I learned something new about licensing so thanks for the interesting read :D
Marked as helpful0@vanzasetiaPosted almost 3 years ago@FluffyKas Hey Fluffy Kas! 👋
Thanks for your kind words! 😊
About the color of the number, yeah, it looks different from the design. 😅 Thanks for highlighting that tiny issue!
Thanks for reading the
README
and glad that you learned something new!0 - @denieldenPosted almost 3 years ago
Hi Vanza, great job!
the logo into
header
is correct...The
main
tag specifies the main content of a document:The content inside the <main> element should be unique to the document. It should not contain any content that is repeated across documents such as sidebars, navigation links, copyright information, site logos, and search forms.
Hope this help ;)
Marked as helpful0@vanzasetiaPosted almost 3 years ago@denielden Hello Deniel! 👋
Thanks for answering my question! Can you please share the site where you quote the statement?
2@EngineerHamzieyPosted over 2 years ago@vanzasetia Hello, How're you doing? Thanks for the other time
I'll very much like you to help review minetoo.
0@EngineerHamzieyPosted over 2 years ago@denielden Hello, How're you doing?
I'll very much like you to help review mine too.
1 - @EmmanuelHexerPosted over 2 years ago
Hi, checked all your projects and i must say, you are really good.
I started programming not long ago, I'm still learning. Can you give me a roadmap on what you did to become good as you are now?
Thanks, Phalcin
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord