Design comparison
Community feedback
- @MaxCoder-mcPosted about 2 months ago
Hello there...
I have few notes that might enhance your solution...
- on big screen sizes you may have noticed that the h1 is getting narrow from the very beginning, probably because of (width: 50%) you set to it. maybe by putting gaps between the (.hero) elements would solve the problem.
- The background image of (.footer) would look nicer if you set the position to top center like this--> background-position: top center;
- Usually we use anchors instead of buttons if the action of it needs to take us to a different web page or have a certain URL...
I hope these notes were helpful to you... Enjoy your coding :)
0 - @NikitaVologdinPosted about 2 months ago
Hi @aouintihouari!
Awesome job! I enjoy how your solution suits designs. I dont know why but in my figma design file I had a bit diffrent hero images and one less main section image.
However, thew things noticed what we can improve here: Font-sizes for desktop version should be: h1 { font-weight: 900; font-size: 4rem; line-height: 110%; } p { font-weight: 500; font-size: 1.125rem; line-height: 150%; } .btn { font-weight: 900; font-size: 1rem; line-height: 150%; } h2 { font-weight: 900; font-size: 2.5rem; line-height: 110%; } .resume p { font-weight: 900; font-size: 1rem; line-height: 110%; } h3 { font-weight: 900; font-size: 2.5rem; line-height: 110%; } Cool work, thank you for reading! Best Nikita.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord