Design comparison
SolutionDesign
Solution retrospective
Any feedback will be appreciated.
Community feedback
- @pikapikamartPosted about 3 years ago
Hey, awesome work on this one. Site looks great in general and it is responsive.
kens_visuals already gave great feedback on this, just going to add a couple of little suggestions:
- Website-logo
img
should be using the website's name as thealt
likealt="meet"
. Remember that a website's logo is meaningful so always make sure it uses the properalt
value. - Also when using
alt
attribute, avoid using words that relates to "graphic" such as "logo" and others. Animg
is already an image/graphic so no need to describe it as one. - Hero-section could use a more proper
alt
text , if you think that theimg
is decoration only, then you can hide it usingalt=""
andaria-hidden="true"
on theimg
tag. - Adjust the
:focus-visible
state for thebutton
tag because right now, it is hard to tell where you are at and the defaultoutline
is not enough. Try looking foroutline
andoutline-offset
. - Add
aria-hidden="true"
to other images to hide them totally. - The
p
tag before the last-section, it uses a largerfont-size
toning it down would be great. - I just noticed it by now, do not use 1440px as the desktop breakpoint. That 1440px on the design is just the size where the design is made and it is not related to the breakpoint. Using 1440px, you are not including lots of users like me who uses 1366x768 resolution. Toning it down would be really helpful so that we won't have to zoom out.
Aside from those, great work again on this one.
Marked as helpful0 - Website-logo
- @kens-visualsPosted about 3 years ago
Hey @kzaleskaa 👋🏻
I just have a couple of small suggestion
- Add
pointer: cursor;
to the:hover
state of the buttons. - And, there's a pretty big gap between the buttons and gallery on mobile viewport width, so in
.header
instead ofmin-height: 100vh;
, I suggestmin-height: 70vh;
I hope this was helpful 👨🏻💻 you did a great job with responsiveness, nicely done. Cheers 👾
Marked as helpful0 - Add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord