Design comparison
Solution retrospective
¿Qué encontraste difícil mientras construías el proyecto?
- Posicionar las cards en el diseño desktop.
¿De qué áreas de tu código no estás seguro?
- Posicionamiento de las cards.
¿Tiene alguna pregunta sobre las mejores prácticas?
- Quisiera saber si tuve errores en mi codificación
Community feedback
- @VCaramesPosted about 2 years ago
Hey @Evan05D, some suggestions to improve you code:
- To give your HTML code structure, you want to set up your code in the following manner:
<body> <header></header> <main> <section> <div class="supervisor-card"></div> <div class="team-card"></div> <div class="karma-card"></div> <div class="calculator-card"></div> </section> </main> </body>The Header Element represents introductory content.
The Main Element identifies the main content of the document.
The Section Element can be used to wrap content that is related to each other.
And since none of the cards make sense on their own, a simple Div will do for each card.
-
The heading is one single heading so the entire thing should be wrapped in a single <h1> Heading along with a Span Element.
-
The icons serve no other purpose than to be decorative; They add no value. There Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.
-
Add a third layout to make the transition from mobile 📱 -> desktop 🖥 views smoother.
Happy Coding! 👻🎃
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord