Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

media query

Brenoā€¢ 40

@Arouca-b

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Minha maior dificuldade Ć© deixar o site responsivo, como posso melhorar meu aprendizado?

Community feedback

Marcos Travagliniā€¢ 4,920

@Blackpachamame

Posted

Greetings! you have done a great job šŸ˜Ž

šŸ“Œ Some accessibility and semantics recommendations for your HTML

  • To improve the semantics of your HTML, you can change your <div class="container"> to a <main class="container"> and the <div class="attribution"> to a <footer class="attribution">
  • The attribution should go outside the main
  • I can only mention an accessibility issue, you can add a short description to your image with the alt attribute. In case it is just a decorative image, such as an icon or logo, you can leave it empty: alt="". More info

šŸ“Œ Some suggestions

  • Use min-height and max-width, this will help the content stretch or shrink if you need to. Unlike height and width which can cause your content to be cut off on certain screens
  • I leave you the task of researching the box-sizing: border-box
  • You can use the gap property in the body to separate your main from your footer
  • Instead of using margin to center your content in the center of the screen, you can use the flexbox properties in the body:
body {
      min-height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
      flex-direction: column;
      gap: 20px; /* Separate the main from the footer */
}

Marked as helpful

0

Brenoā€¢ 40

@Arouca-b

Posted

Muito obrigado pelo feedback!! @Blackpachamame

1
Josh Michaelā€¢ 1,050

@joshmichael23

Posted

Removing the height: 80% and adding maybe a little bit of padding for the top and bottom will make it more neat across all devices. Right now there's some extra space when the height of the device is a bit too high. Overall good job!

0

Brenoā€¢ 40

@Arouca-b

Posted

Certo, muito obrigado pela ajuda!! @joshmichael23

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord