@Blackpachamame
Posted
Greetings! you have done a great job š
š Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="container">
to a<main class="container">
and the<div class="attribution">
to a<footer class="attribution">
- The
attribution
should go outside themain
- I can only mention an accessibility issue, you can add a short description to your image with the
alt
attribute. In case it is just a decorative image, such as an icon or logo, you can leave it empty:alt=""
. More info
š Some suggestions
- Use
min-height
andmax-width
, this will help the content stretch or shrink if you need to. Unlikeheight
andwidth
which can cause your content to be cut off on certain screens - I leave you the task of researching the
box-sizing: border-box
- You can use the
gap
property in thebody
to separate yourmain
from yourfooter
- Instead of using
margin
to center your content in the center of the screen, you can use theflexbox
properties in thebody
:
body {
min-height: 100vh;
display: flex;
justify-content: center;
align-items: center;
flex-direction: column;
gap: 20px; /* Separate the main from the footer */
}
Marked as helpful
@Arouca-b
Posted
Muito obrigado pelo feedback!! @Blackpachamame