Skip to content
Submitted 7 months ago

media query for responsive website

Ankita Joshi•10
@ankitajoshi060
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?
  • For the first time I have used figma without knowing how to use it
  • I have created this website using tag only but if i have to make changes then i will use grid or flex to design QR component
  • Successfully created responsive desing.
What challenges did you encounter, and how did you overcome them?

Learned how to design a responsive website

What specific areas of your project would you like help with?

I am looking for feedback on how I optimize my css code

Community feedback

  • eren•300
    @erensaracPosted 7 months ago

    Congratulations! @ankitajoshi060

    I reviewed your solution. I really liked your first attempt at creating a responsive design. I have some feedback for you. In your solution, It looks like you used div tags for all texts. You can use h1 tag for title, p tag for description. In this way, your codebase will be easier to read and compatible semantic html. Also I have suggestions for your class naming, you should use descriptive names. text-1 and text-2 it doesn't explain the tags. In your style file, it appears that you've used absolute length units. For responsive design, it's recommended to use relative length units instead.

    I recommend these resources for you.

    Happy coding!

    Marked as helpful
    0
    Ankita Joshi•10
    @ankitajoshi060Posted 7 months ago

    Thank you for feedback. I'll improve my solution @erensarac

    0
    Ankita Joshi•10
    @ankitajoshi060Posted 7 months ago

    Thank you for feedback. I'll improve my solution @erensarac

    0
  • Heaths•10
    @Heaths-707Posted 7 months ago

    great job

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord