Skip to content
Submitted 5 months ago

Media query for responsive landing page and flexbox for outline

Christine•10
@Christine919
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Understand how to use Flexbox.

What challenges did you encounter, and how did you overcome them?

Align the layout.

What specific areas of your project would you like help with?

I'm struggling with aligning text or images properly.

Community feedback

  • Alex•3,130
    @Alex-Archer-IPosted 5 months ago

    Hi! It's a good work, well done =)

    I can give you a couple suggestions how to improve it.

    • Keep your styles in the separate file - it'll improve readability and make easier future maintain of the project.
    • Try not to set explicitly height property for the container. In real projects the content may change time to time, so it's better if the content will determine the height of container.
    • Use rem values for font-size properties. It's a special values which depends of user's font-size settings. By default 1rem = 16px.

    Oh, and your image doesn't load due incorrect path. Maybe cos your github page repo have different folder structure.

    Hope some of this could help =) Happy coding =)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord