@Alex-Archer-I
Posted
Hi! It's a good work, well done =)
I can give you a couple suggestions how to improve it.
- Keep your styles in the separate file - it'll improve readability and make easier future maintain of the project.
- Try not to set explicitly
height
property for the container. In real projects the content may change time to time, so it's better if the content will determine the height of container. - Use
rem
values forfont-size
properties. It's a special values which depends of user's font-size settings. By default1rem = 16px
.
Oh, and your image doesn't load due incorrect path. Maybe cos your github page repo have different folder structure.
Hope some of this could help =) Happy coding =)