Media Queries, Position Absolute (center the card)

Community feedback

• 

  Adriano•41,020

  @AdrianoEscarabotePosted about 2 years ago

  Hi Dilhan Boca, how are you?

  Congratulations on completing another challenge!

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  • The links must have an aria-label or sr-only text that tells where the link navigates the user. For example: Visit our Facebook. For images, you should set aria-hidden=”true” to be ignored by screen readers and to avoid redundancy and repetition.
  • You have used <br>, using <br> is not only bad practice, but it is also problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader. You can read more in MDN.

  For a user to know that the element is clickable, use the cursor: pointer; property:

  button {
     cursor: pointer;
  }
  

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  P

  Dilhan Boca•220

  @dboca93Posted about 2 years ago

  @AdrianoEscarabote Hello Adriano,

  Thank you so much for your feedback, I really appreciate it. I've applied the changes you've made. I would love to get your feedback into the future. Who knows, maybe if my skills improve enough one day we could collaborate :)

  0

  

  Adriano•41,020

  @AdrianoEscarabotePosted about 2 years ago

  @dboca93 clear! it would be really cool!

  Marked as helpful

  0