@Stroudy
Posted
Hello, Great job with this challenge I can see you put a lot of effort in and trying to go beyond the scope of the challenge, couple of things I noticed,
- You should avoid using
pxas it is an absolute unit and not a responsive unit likeremorem, this is a great site, px to rem converter and you should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - I ran Google Dev tools, Lighthouse, score was 91 out of 100 for SEO, you can make this 100 by putting a
<meta>description tag in the head. - By default
<h1>tags have afont-weight: boldif you change it tofont-weight: normalit will match the brief. (I know this because I had the same issue) - Using
max-width: 100%ormin-width: 100%is way more responsive then justwidth:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
I look forward to seeing more from you, good luck and I hope some of this information help 🎉
@coding-vasu
Posted
@Stroudy Thanks for your valuable feedback.
I have updated my code
- converted px -> rem
- Updated the code as per lighthouse suggestion
- h1..h6 (font weight: bold -> normal
- I am thinking of clamp to make me page responsive need to learn more
@Stroudy
Posted
@coding-vasu, Your more than welcome 😁
@coding-vasu
Posted
@Stroudy , One last thing. I have gone through your few of your preview sites, I see that you are able to use GitHub pages for multiple repositories. Could you please let me know how did you achieved it.
Thank you!
@coding-vasu
Posted
@Stroudy , One last thing. I have gone through your few of your preview sites, I see that you are able to use GitHub pages for multiple repositories. Could you please let me know how did you achieved it.
Thank you!
@Stroudy
Posted
@coding-vasu No problem, open up github.com, find the repository you want click on it, Then click on settings at the top, On the left click on pages, Then under branch, hit the drop down hit main then next to it select /root. Wait 5 mins and a link will appear with your website just above it when you refresh super easy.
