media queries and html

Community feedback

• 

  Eduardo Godoi da Silveira•90

  @GodoiTheCreatorPosted over 1 year ago

  • Hi! Great code, congratulations!

  I'll give you some tips, as a begginer too

  • To move something to the middle of the div, you need to add the align-items: center or justify-content: center, so your items will be centralized on the div. But, if you want to limit the space that they will fill, you still need to use the margin or padding properties.

  • To centralize the div in the entire body, you can say that the body is using display: flex and use the properties that I said earlier. To centralize something horizontally, use height: 100vh, this will allow your display flex to centralize horizontally.

  • Also, in the next challenge, try to import the text font, you'll see what font they are using in the style-guide.md file, click in the font name and you'll be redirected to Google Fonts, where you can import to your css.

  • FrontEnd Mentor give you hints of how to "correct" the semantics of your code, in this case, it's interesting to use a div called main and put all the elements inside that div, because it's the main content of your website. And change the default attribution name to footer, this turns your code way prettier and accessible.

  I'm just trying to help the community, none of these tips are a criticism

  0

  ---

  

  eve•230

  @Eve-WangariPosted over 1 year ago

  @GodoiTheCreator Thanks alot. I look forward to learning more and improving my skills. I made all the recommended changes, now all I have to do is update my git repository.

  1