Marvel quote generator with Marvel API and CSS Grid

Community feedback

• 

  joost elshof•20

  @elsh5544Posted over 2 years ago

  Hey haico. Nice idea to make use of a Marvel quote API.

  I have spotted an issue though. This API sometimes returns a very large quote and because of this the button for the next quote falls off the screen within my desktop browser. I can't scroll to reach the button when the text gets to large but i have been able to reach it again by using the zoom functionality. Consider allowing to scroll when the quote becomes to large.

  Good job!

  Marked as helpful

  1

  ---

  

  Haico Paulussen•170

  @Haico-PaulussenPosted over 2 years ago

  Hi @elsh5544.

  Thanks for your comment. I was a bit to fast with testing the app so i didn't get to see a very large quote. But now I have and I fixed the issue.

  Thanks and happy coding!

  0
• 

  Mark Teekman•365

  @markteekmanPosted over 2 years ago

  Hey Haico! Love your use of Marvel quotes, big fan of Marvel myself 🙂 Don't know if it's possible with the API you've used, but it would be cool to see the person behind the quote e.g. "You took everything from me." - Wanda. Just an idea though.

  To improve the accessibility and the usability of your solution a bit, consider using cursor: pointer; for when you're hovering over the randomization button.

  Great work Haico!

  Marked as helpful

  0

  ---

  

  Haico Paulussen•170

  @Haico-PaulussenPosted over 2 years ago

  Hi @markteekman!

  Thanks for your comment. I fixed the 'issue' and added the pointer.

  Thanks!

  1