margin:auto; and float

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hey Razha, congratulations on completing the challenge! You did a great job 😉

  Let me give you some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • avoid using inline style inside html document, but create class inside css stylesheet
  • use button element for the buttin submit instead of a div
  • I can also submit without selecting anything, add a control
  • to make it look as close to the design as possible add the background-color to body
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of title
  • remove all margin from .wrapp class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😁

  Marked as helpful

  1

  ---

  

  Razha Jamsik Syah•700

  @Razha90Posted over 2 years ago

  @denielden thank you daniel, you want to review my code. I'm still a noob, sorry 😁 😁 😁

  1