Skip to content
Submitted over 1 year ago

Margin shorthand,

Ashum91•50
@Ashum91
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What did you find difficult while building the project? I found it difficult to centre the QR code, text to the webpage.

Which areas of your code are you unsure of? I googled reset CSS which I had added it in to the code so the webpage could be viewed the same whatever device is being used. I am unsure if I was successful in doing so.

Do you have any questions about best practices? A tip I have heard is to start off with mobile before desktop, what would be the best way of me doing so? It would be the layout of the code. Is there a way to make it more neat?

Community feedback

  • Manish Patel•730
    @savvystriderPosted over 1 year ago

    Looks good!

    • Your reset CSS file is empty, so I'm not sure it's doing anything for you at the moment.
    • On wide screens, there's too much whitespace in the main element.
    • If you want a mobile-first approach, start with min-width media queries and then build out from there.
    Marked as helpful
    0
    Ashum91•50
    @Ashum91Posted over 1 year ago

    @savvystrider thank you! 😀

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord