margin , padding , background-color , display

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @hossamyosri, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.
  • When you download the project files there’s a file called style-guide.md where you can find information such as hsl color codes and the font-size for the headings. The background-color in this case is background-color: #D5E1EF

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  0
• 

  Youssef Waleed•200

  @ywsolimanPosted about 2 years ago

  Hey @hossamyosri, I hope you're doing great!

  I have some suggestions for your code if you don't mind:

  • You should use HTML Semantic Elements instead of div as it doesn't have a real meaning <div> should be <main> because the main element identifies the main content of the page.
  • From a semantic point of view, using an h3 without an h2 or h1 is not good practice.
  • You should center the QR component horizontally and vertically using CSS Flexbox or CSS Grid instead of using margin.
  • Use relative units such as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

  Keep up the good work!👏

  0