Submitted almost 2 years ago

margin and border-radius

Metin AKIN• 120

@Rheomacrodex

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

First of all margins is difficult for me

Community feedback

Melvin Aguilar 🧑🏻‍💻• 61,220

@MelvinAguilar

Posted almost 2 years ago

Hi @Rheomacrodex 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

Here are some suggestions you might consider to improve your code:

Your solution should contain a title tag with the name of the challenge and an icon.

<title>Frontend Mentor | QR code component</title>
<link rel="icon" type="image/png" sizes="32x32" href="./favicon-32x32.png" />

Try to use semantic tags in your code. Click here for more information.:

With semantic tags:

<body>
   <main class="main-container">
      . . .
   </main>
<body>

Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
The container isn't centered correctly. You can use flexbox to center elements:

body {
  width: 100%;
  min-height: 100vh;
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
}

Links with more information:

I hope those tips will help you.

Good job, and happy coding!

バレンタイン 😈• 64,190

@VCarames

Posted almost 2 years ago

Hey there! 👋 Here are some suggestions to help improve your code:

To help identify the main content of you site you will want to encase your entire component inside a Main Element.
The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
Change width to max-width in your component’s container to make it responsive.
Change width to max-width: 100% in your image to make it responsive. You will also want to remove the height as it is unnecessary.

If you have any questions or need further clarification, let me know.

Happy Coding! 👻🎃

Fahad Nawaz• 20

@Fahadnawaz007

Posted almost 2 years ago

Good effort brother. Keep it up you're doing great.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord