Skip to content
Submitted about 1 year ago

Manage-Landing-Page-Solution

Sadia Imran•220
@SadiaImran
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Manage landing page
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Community feedback

  • Atif Iqbal•3,200
    @atif-devPosted about 1 year ago

    Hi, congrats🎉 on completing the challenge. Better take care about following points.

    • Testimonial horizontal scroll and vertical scroll don't look good. Make it according to design
    • When we click on testimonial button above text and images change.
    • <button id="get-started">Get Started</button> hover effect not good.
    • Click on email input field then click anywhere on screen you will see invalid email message. (Invalid email message should only appear on button click)
    • Responsiveness is also not good, you need to work on responsiveness.
    • You must be seeing some acceessibily issue in code after project submission. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
    <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>
    • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.

    --Got any questions, REPLY--

    Hope you will find this Feedback Helpful.

    Let's connect for learning📝 and sharing🤝. Twitter , LinkedIn , GitHub

    1
    Sadia Imran•220
    @SadiaImranPosted about 1 year ago

    Hello! Thank you for your feedback.

    I agree that the testimonial scroll doesn't align with the design as intended.

    Regarding the testimonial button issue, it appears to be a temporary test run problem, and I mistakenly left it in the JavaScript file. My apologies for the oversight.

    As for the email issue you mentioned, it also seems to have stemmed from a test run that I forgot to remove from the JavaScript file. My bad! I'll certainly check into it, though it doesn't seem to be a significant concern.

    I'm actively working on improving the responsiveness of the website. It's worth noting that the desktop and mobile designs are pretty similar to the original design.

    Your feedback is greatly appreciated, and I'm committed to addressing these issues promptly. I will submit my updated solution for these problems as soon as possible. Thank you for bringing them to my attention!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord