Skip to content
Submitted over 4 years ago

Manage landing page | HTML SCSS and JS with slick slider plugin

Connor Z•5,115
@zuolizhu
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Manage landing page
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

Feedbacks are super welcome!

The slick slider will generate the id attribute with an empty value, which caused the HTML validation issues. I walked through the documentation and haven't found a way to remove the generated id attributes yet. Anyone know how to deal with it?

Thanks a lot!

Community feedback

  • Matt Studdert•13,611
    @mattstuddertPosted over 4 years ago

    Nice work on this challenge, Connor. Pretty much pixel-perfect, again! 🙌

    That's an annoying issue with the empty IDs. Perhaps you could find all elements with an empty ID attribute after they're created and then remove the whole attribute? Not sure that would remove the validations errors though. Some libraries and frameworks cause validations issues but they're often not a major issue. This wouldn't be causing any accessibility issues or anything. It's just a little frustrating!

    Just a quick heads up that on mobile there seems to be a large gap at the top of the screen before you see any content.

    Keep up the awesome work 👍

    1
  • Chio•210
    @silfrido-labPosted over 4 years ago

    Excellent work. You have a very good eye. Congratulations!😁

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord