@0xabdulkhaliq
Posted
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution generates accessibility error reports due to
non-semantic
markup, which confueses landmark for a webpage
- So fix it by wrapping the whole content with semantic element
<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
JavaScript π·οΈ:
- The way you declared variables are need to be well structured and organized
- Take a look at the following example code which describes an efficient way of declaring variables
const firstName = "Your";
const lastName = "Name";
const emailAddress = "[email protected]";
const password = "supersecret";
- instead try this,
const firstName = "Your",
lastName = "Name",
emailAddress = "[email protected]",
β’β’β’
- This single line declaration with separated commas will helps you to have a better structured code and improves readability though
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful