Maker pre-launch landing page

Community feedback

• 

  Michal•665

  @mbart13Posted over 3 years ago

  i'd only suggest to turn off html form validation with 'novalidate', since you are doing it with js

  Marked as helpful

  1

  ---

  

  Alain•205

  @Alain-sysPosted over 3 years ago

  @mbart13

  Thanks, Michal ! It's very interesting because I didn't know the existence of 'novalidate' before you answer me. I added it and modify my js for a better code. 😊

  0
• Account deleted

  Good job on submitting your first challenge.

  Desktop view looks good, just that you have a little problem with the 'zig-zag' thing behind the email section, you need to set it's container to overflow : hidden, I'm sure that'll solve the problem.

  Keep coding👍.

  Marked as helpful

  1

  ---

  

  Alain•205

  @Alain-sysPosted over 3 years ago

  @thulanigamtee

  Thanks, Thulani ! Yes, as you saw it, the overflow was the problem but fortunately for me when I added overflow-x: hidden in the html{} it solve the problem. 😃

  0
• 

  Nebiyou Ersabo•185

  @NebiyouErsaboPosted over 3 years ago

  Hello Alain-Sys,

  I think you have done a great job on this challenge. Your page is nicely responsive as well 👍.

  I was having some problems when inspecting your page for responsiveness on chrome (the .img-hero-right and the .footer-squiggle svgs were extending way far to the right, making your page align to the left), but it was okay when I opened your page on safari. Not sure if it is my problem or that you haven't used some cross-browser css properties.

  But overall you have done an awesome job on your first project! 🙌

  Marked as helpful

  1

  ---

  

  Alain•205

  @Alain-sysPosted over 3 years ago

  @Nebiyou12

  Thanks, Nebiyou ! I have forgotten to see my website on other browsers ! 😅 I have seen the problem and correct him. It was the overflow-x: hidden who need to be write in html{}. 🙂

  0