Maker pre-launch landing page

Community feedback

• 

  Finney•3,030

  @Finney06Posted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  Here are some suggestions regarding your code that may be of interest to you.

  HTML 🏷️:

  To clear the Accessibility report:

  • Wrap the page's whole main content in the <main> tag.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy.

  • Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections.

  Here is a web accessibility evaluation tool📕 to check your webpage for any remaining errors or warnings related to landmarks.

  I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

  Marked as helpful

  1

  ---

  

  Wiks•750

  @wiksmfPosted over 1 year ago

  Hi @Finney06 :D

  Thanks so much for the feedback, I will work on improve my solution :)

  0
• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Great job in completing the challenge successfully! Your solution looks great overall, the design implementation is simple neat. Both mobile and desktop view respond well to resizing.

  One little thing to add would be to add some hover states and cursor:pointer; for the button. You can change its background color on hover for example and add some transition like transition: background-color .4s ease; for a smooth transition.

  If this was helpful, feel free to mark it as helpful! Good luck on upcoming projects!

  Marked as helpful

  1

  ---

  

  Wiks•750

  @wiksmfPosted over 1 year ago

  Hi @visualdenniss :D

  Thanks for the feedback, I definitely need to add some hover states and the cursor:pointer for the button :)

  0