Maker Landing Page

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 1 year ago

  Hey,

  Your solution looks really nice! Just one thing: your email validation seems off? I could submit the following as a valid email address: kitten@kitten, though this obviously shouldn't pass as valid. Is there a reason you're not using email type input instead of text? If there is, you could double check how the validation is being done. I'm not familiar with Yup but there seems to be a problem with either this:

   const validationSchema = Yup.object().shape({
      email: Yup.string()
        .email("Oops! That doesn’t look like an email address")
        .required("Oops! Please add your email"),
    });
  

  or rather how you pass in that validationSchema. Either case, it's worth checking. Apart from this, great job (:

  0