Design comparison
Solution retrospective
I was quite addictive of using position to relocate elements to their perfect location however, this time taken a challenge to use less position and manage to perform to task beautifully using margin and padding instead of position.
In terms of interactivity it was quite easy only needed to validate email. Please share your views regarding this challenge .
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
JAVASCRIPT 🟡:
- The way you declared variables are need to be well structured and organized
- Take a look at the following example code which describes a better way of declaring variables to have a well structured code
const firstName = "Your"; const lastName = "Name"; const emailAddress = "[email protected]"; const password = "supersecret";
- instead try this,
const firstName = "Your", lastName = "Name", emailAddress = "[email protected]" ••• ••• // n number of declarations password = "supersecret"; // make sure to add a semicolon at end of last declaration
- This single line declaration with separated commas will helps you to have a better structured code and improves readability though
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @josh76543210Posted over 1 year ago
Hello @Sanjeet204,
Congratulations on completing the challenge!
Here is another suggestion to improve the look of your page:
Center the social media icons inside their respective divs using flexbox instead of
padding
. The divs are already displayed asflex
so all you have to do is addalign-items
andjustify-content
. These can be used to center the flex-items (in this case the icons) vertically and horizontally.Just add them to your divs like this:
.icons > div { align-items: center; justify-content: center; }
And then remove the
padding
:.icons > div { padding-top: 11px; padding-left: 11px; }
Your icons should now be perfectly centered inside your divs.
Hope this is useful. Happy coding!
Marked as helpful0 - @Shivraj-K09Posted over 1 year ago
- Great job! It's good to see that you were able to achieve the desired layout using margin and padding instead of relying solely on positioning.
- One suggestion I would make is to use
const
instead oflet
when declaring pattern since the variable doesn't need to be reassigned. It's a small change, but it can help communicate to future readers of the code that the variable is intended to be constant.
Keep up the good work! and Happy Coding 😉🫡
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord