Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Made with sass

@jampiers

Desktop design screenshot for the Bookmark landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi guys, could you please tell me if i am using the best practices?

Community feedback

David 8,000

@DavidMorgade

Posted

Hey man, congrats on finishing the challenge!

The projects looks pretty good and is completely responsive so, good job on that.

It would be pretty good if you upload your SASS files to the github repository too so we can see the build process of your project.

Also, I would recommend you to use a naming convention, like BEM, it will make your project more clean and easy to name classes and when using SASS is even more powerfull. You can look on how BEM works, here.

With BEM you will be able to nest your SASS even better, for example:

.section {
    

    &__heading {

    }

    &__img {

    }
}

Hope my answer helps you!

Marked as helpful

1

@jampiers

Posted

@DavidMorgade thanks for answering my question, i have also used bem with other projects, but in this one i wanted to practice the nesting without bem because i was forgeting of it

And i will also upload the sass files right now

B)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord