made with React and CSS

Community feedback

• 

  Aleksandr Aksenov•750

  @axevldkPosted almost 4 years ago

  Hi, Carlos Taracena ~ I have studied your work. Good work on your first React challenge ~ Here are some of my opinions on your work.

  1. Background is weird on desktop version. I am not sure about the reason, but html and body doesn't fit even 100vh. So background gradient is being repeated.

  2. Box on the left from design is missing.

  3. I think it would be better to use ul and li tags for accordion items.

  4. You used image tag for arrows on each faq items, but I think using pseudo elements would be appropriate in this case.

  5. Hope to add sliding animation on faq items to make your work more wonderful.

  6. On 320px resolution, there is no padding between page wrapper and card element. I think you can add max-width style property to card.

  Hope my opinions can help you even a bit. Happy coding ~ ✨

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Carlos Taracena! 👋

  Good effort on this challenge! 👍

  Just wanted to say that there's actually a separate illustration image that comes with the design for the mobile layout of the site. It includes the floating cube in the illustration so you don't have to add it yourself in the mobile layout. 😀

  I also suggest not using viewport units when using absolute positioning to position the illustration, since that means the illustration will move around a bit when the page is resized. Instead, used fixed units and position the illustrations relative to what you want them to stick to (just make sure the element you want them to stick to is a parent element). 😉

  Keep coding (and happy coding, too)! 😁

  0
• 

  Carlos Taracena•495

  @CtaracenaPosted almost 4 years ago

  Thank you very much for Your time And Your opinion, I'll work on that issues

  0