Made with HTML and SCSS

Community feedback

• 

  Walter Sono•660

  @waltersonoPosted over 3 years ago

  Hi rks1995, nice work

  The design looks good,

  Aside from what Vanza said, here are my suggestions:

  • Use the correct README.md file

    • Use the template provided in the resources, people are going to look at your repository and they need to understand what is the project about

  • Give an alternative text to each image

    • This helps screen readers users understand your content

  • Use the correct HTML tag

    • If you have a header use the header tag
    • The main tag should not contain the header, nor a footer
    • Every web page should have an h1

  • Use the headings in order

    • I see a h3 but i do not see a h1 nor a h2
    • This causes confusion to screen readers users when browsing through your page

  • Add an hover effect to the buttons and links

  • Add links to your footer items

  Ok rks1995, hope this is helpful.

  3

  ---

  

  Ratna Kumar Singh•250

  @rks1995Posted over 3 years ago

  @waltersono thankyou for your valueble feedback walter.

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋Hi Ratna Kumar Singh! My name is Vanza!

  I have some feedback that will improve this solution:

  • If you open the dev tool, then set the width of this page to 360px, now you may notice that the container width is too small. Try to fix this by using padding-right and padding-left instead of using width: 50%.
  • On the feature img inside @media screen and(min-width:720px) try to use flexbox or grid instead of float.
  • In my opinion, on this solution you use width with % unit too much like on button and header since the header is wrapped by container and for the button you set the width: 30%, it will become a wide button if the screen width is getting bigger. So my recommendation is that try to use padding for the button and you can change the width on header to be fixed unit like rem or px.
  • Try to set the header as default styling, to prevent you from keep repeating .clipboard header .last header.

  That's it! Hopefully this is helpful!😉

  Happy Coding!

  2

  ---

  

  Ratna Kumar Singh•250

  @rks1995Posted over 3 years ago

  @vanzasetia thankyou for your valuable feedback i think your suggestion are quite helpful.

  0