Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

made with css

mucahitozturkesβ€’ 330

@mucahitozturkes

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have a suggestion regarding your code that I believe will be of great interest to you.

CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.
  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states
  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here πŸ“š.
  • For this demonstration we use css Grid to center the component.
body {
    min-height: 100vh;
    display: grid;
    place-items: center;
}
  • Now remove these styles, after removing you can able to see the changes
.wrapper {
  width: 340px;
  margin: 30px auto;
}

@media (min-width: 542px) {
  .wrapper {
    margin-top: 200px;
  }
}
  • Now your component has been properly centered

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

@Harsh-Kumar-Dwivedi

Posted

Hi @mucahitozturkes,

Nice Solution !

I would suggest following:-

1.Prefer replacing <div class="wrapper"> with <main> element.

2.<div class="img-container">, <div class="img"> are redundant. Only 1 container would be sufficient.

3.<div class="wrapper-infos">, <div class="info-container"> are redundant. Only 1 container would be sufficient.

4.Prefer using heading tags in hierarchical order, not for the purpose of text size or weight or both.

These will improve your code, enhance accessibility and make your markup more structured.

Hope these suggestions are helpful !

Stay Happy and Healthy !

Happy Learning !

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord