Made with CSS flexbox, love and patience.

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • It is simply due to the h1 element is standing alone inside body element. Where the main is also a child of body. So we can fix the accessibility issue by nesting the h1 inside the main

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  SrHatcher•710

  @SrHatcherPosted over 1 year ago

  @0xAbdulKhalid I was thinking about it but I didn't understand it at first when I saw the accessibility report. But now it's clear, Thank you!

  0