Design comparison
Solution retrospective
Project was easy, but there could be issues. point em out please...
Community feedback
- @luztherosePosted about 2 years ago
Hi Ben,
Congratulation on completing this challenge. Your solution looks great. I have some suggestions regarding your solution if you don’t mind:
-
When writing your HTML always try to use semantics elements whenever possible. For example header, main, footer, etc.
-
The text for the alt="code" attribute tries to make it as descriptive as possible since this is the text that will be displayed if the image cannot be loaded.
-
Since you are using an external stylesheet which is excellent, you could move the style that is written internally in the HTML for the footer to your external CSS and remove it from your HTML.
Overall Excellent work! Hopefully, this feedback helps.
Marked as helpful1 -
- @damiandev22Posted about 2 years ago
Hello and congrats, you did well on this challenge. I think that In order to achieve a most acurate result you could measure the card in the given design, so you can have an idea of the size the card should have in your solution. for that you can use Photoshop because doing so blindy is more difficult. in this challenge the card has 320px wide. Only that for now. keep up.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord