Skip to content
Submitted about 2 years ago

Made this using HTML and CSS

Rachit Patel•540
@rachit0706
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Any constructive suggestion would helpful :)

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hello @rachit0706, Congratulations on completing this challenge!

    Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:

    1.Add the website favicon inserting the svg image inside the <head>. <link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">

    2.Replace the <h4> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

    3.Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
  • Rachit Patel•540
    @rachit0706Posted about 2 years ago

    Thank you very much Lucas for sharing your valuable feedback. I read your suggestions and have made some changes. Please take a moment to again look on the project (preview site and code) and give any any more suggestions you have regarding this.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord