Made this HTML, CSS and Sass

Community feedback

• 

  Radomir Josifovic•140

  @radomirjosifovicPosted over 2 years ago

  Hello, excellent work mate! I'd like to point out a few things that could be worked on to make this project even better:

  • You should add border-radius only on the first the boxes(orange(border-radius: 10px 0 0 10px;) - which will add on border-radius on top and bottom left side of the box and on very dark cyan box(aka last one - border-radius: 0 10px 10px 0 - which will add border-radius on top and bottom right side). As for the box in the middle, no border-radius is needed.
  • You should use different color styles for headings and paragraphs.
  • On the button you should make it to be transparent on hover (background: transparent) as well to add border on hover.

  Hope this helped you out a little bit, Happy coding!

  1
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge

  Keep up the good work

  Your solution looks great however I think that your individual cards are a bit too wide, secondly the button has too much margin on the bottom and lastly on the first and last cards should have border radius using the following

  • border-top-left-radius
  • border-top-right-radius
  • border-bottom-left-radius
  • border-bottom-right-radius

  In terms of accessibility issues simply wrap all the content between main tags

  I hope that helps

  Cheers Happy coding 👍

  0
• 

  Foster Asare•50

  @FosterSOAsarePosted over 2 years ago

  I have the hover states implemented, I also the rounded borders for each on purpose. I have to take a look at the colors for the heading and paragraph. Thanks for the feedback.

  0

  ---

  

  Radomir Josifovic•140

  @radomirjosifovicPosted over 2 years ago

  @Dead-Alnix My bad then, when i loaded the site it didn't show hover states.

  0

  

  Foster Asare•50

  @FosterSOAsarePosted over 2 years ago

  @radomirjosifovic What about now?

  0