Made in HTML and using SASS for the first time

Community feedback

• 

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  hey @edycerpa great work on this one - it looks lovely! 🙌 I have also only just started SASS, and I have to say after a couple of challenges I'm really starting to love it. But I also found it really tricky to change over from regular CSS.

  I would really suggest trying a couple more challenges and see if you get comfortable with it. That said, I really made sure I was OK with the CSS basics, and how I structure my code before trying it - so I wouldn't rush into it.

  Some small suggestions on this challenge:

  1: It looks great at large viewports, but at smaller screens the margin on the bottom of the phone pushes the text quite a way off screen - you might want to reduce this?

  2: I would consider using background-image for the background images rather than the body-bg divs you have at the moment. This will just make your code cleaner.

  3: Semantically this one is tricky, and up for debate for sure, but I would consider putting all the messages in a ol and have them as li items?

  4: Lastly, and I think I'm on stronger ground here, I would suggest the msg area at the bottom should be an input with the submit element as a button.

  Really nice job though 👍 Keep up the great work!! Cheers 👋

  1

  ---

  

  Eddy Cerpa•145

  @edycerpaPosted over 3 years ago

  @dwhenson Hi, thanks for taking the time to review my challenge. Of course I'm going to keep trying with SASS, there is good reason professionals use it.

  1.-It is a bit strange what you tell me, since before uploading the result here, I tested it in various browsers on PC and mobile, and everything looks fine.

  2.-I still don't know how to use background-image without having an image, I'll have to do some research on that, thanks for the advice.

  3.- It's a good idea maybe, but I don't really like to use lists when it's not totally necessary. Still, I'll keep it in mind.

  4.- You are absolutely right at this point, the challenge is an App simulation and I did everything as if it were an image, my mistake. I'll fix it by doing the whole challenge again but I'll do it mobile-first as I want to practice it.

  Thanks again for taking the time, Regards

  0

  

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  @edycerpa you are right, background image may note be the way to go here. I just checked my solution and I used pseudo elements. That might work better.

  Also I just checked on my phone and the page looks perfect! I think it must be something strange when I put my desktop browser in mobile mode?

  Sorry about that.

  0