loopstudios-landing-page using html,css and js

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 1 year ago

  Hey there! 👋 Unfortunately, there are a lot of mistakes been that I would not expect at this challenge level.

  I noticed that you are not receiving feedback in your previous challenges, In that case I would recommend reading the feedback others receive to improve all your previous challenges.

  Here are some suggestions to help improve your code:

  • The header should always be outside⚠️ of the main element to make semantic sense.

  • Swap <section class="banner-section"> with a header element and <header class="header container"> into a div.

  • The logo's anchor should have an aria-label⚠️ and it should state the company's logo name and where it leads to.

  • There is NO❌ reason to have code for two separate navigation menus. There should only be one and you will CSS to style it for different layouts.

  • The navigation "button" has to be a built using a button⚠️ since it doing an action (open/close menu); Currently, it is not accessible.

  • Text should not be all uppercase <h1 class="hero-h1">IMMERSIVE EXPERIENCES THAT DELIVER</h1> as it is not screenreader friendly😢, instead use CSS to do so.

  • The buttons in the creation portion should be anchor⚠️ elements, as they would most likely direct users to other parts of your site.

  • Skipping heading levels is something that is not allowed❌ in web dev. In your case, you can't jump from h2 to h4.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 👾

  Marked as helpful

  0
• 

  Mibenin•490

  @MIBENINPosted about 1 year ago

  Thank you for your valuable feedback! I will surely make use of these suggestions while doing upcoming challenges..Please evaluate my previous challenges also.It will be very helpful for me to learn from my mistakes..

  0