Loopstudios-landing-page using HTML CSS and J.S

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Tesla_Ambassador! 👋

  Good effort on this challenge! Your solution responds well. Here's my few suggestions:

  • Since your .logo-top, .desktop-size images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.
  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 3 years ago

  @tediko Thanks a lot, it was really helpful. I will add focus to the button element. I really appreciate it.

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  well the first thing I would work on is your mobile menu if you open the mobile menu and then drag the window to desktop size your mobile menu hangs open

  also on the big card resizing downwards instead of keeping 4 big cards on 2 rows it you transitioned the big card to 2 cards and 4 rows then it might make for a better transition

  dragging the browser window from mobile to desktop and back again and looking at the placement of each element and how they transition while you code is a good idea

  1

  ---

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 3 years ago

  @palgramming Thank you very much for the feedback, it's much appreciated.

  0