Design comparison
Solution retrospective
On to the next one!
Community feedback
- @FluffyKasPosted about 3 years ago
Hey, your solution looks really great on all screen sizes! I'm only going to add some notes on accessibility/semantic stuff.
-
Footer links section: it would be much more semantic if you used a list here (<ul>) instead of
div
, then embed a link inside each <li>. Like you did in the header with the nav links (although in the mobileLinks, you forgot to add <a> tags, you only used <li>s). -
Social icons: this should be a list too, or at least they should be links instead of just plain images. In this case, you'll need aria-labels for them too, since they don't have any visible text description.
-
Alt texts: they don't need to include words like image, picture, logo, etc, the screen reader will tell the user what it is. More on this here.
I loved the View Experience that you added though! That looks really neat ^^
EDIT: one more thing I forgot and it's an important one :) I saw you removed outlines. They have a very important role so removing them is bad practice. Instead of doing that, you could add your own custom outlines so they look better with the style of the website. Check this for more info.
Marked as helpful2 -
- @Vahe-SevachyanPosted about 3 years ago
Thanks for the feed back! I'll definitely look into it.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord