Design comparison
Solution retrospective
Hello✋ This is my take on loopstudio landing page using grid css.
I explored different media queries for multiple screen sizes using grid. I had difficulty doing the navigation for the small screens especially the placing the logo. if there's a good way of doing that please let me know. I thought I needed js..i didn't end up using it, but i might change up my hamburger to js later, so I left the file there for later.
also, my html accessibility says i cannot nest anchor tags in my ul... is that true? i wrapped my li with anchor tags, because i want them to be links.
all feedback is very much appreciated! happy coding 😀
Community feedback
- @ApplePieGiraffePosted almost 4 years ago
Hi there, nicole-nam! 👋
Good work on this challenge! 🙌 I like the animation of the mobile navigation menu icon! 🤩
There's a lot of extra white space between the header and the "THE LEADER IN INTERACTIVE VR" section below it on my desktop screen. Decreasing that space to bring the elements of the page closer together would be a good idea.
About those issues on your solution report, simply wrapping the anchor tags in the
<li>elements (not the other way around) should solve your problem. 😉Keep coding (and happy coding, too)! 😁
0@nicole-namPosted almost 4 years ago@ApplePieGiraffe I will try wrapping them the other way around and get rid of too much white space 😀. Thank you so much !
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord