Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Loopstudios landing page solution using SCSS, flexbox, grid

P
Amit-R328 150

@Amit-R328

Desktop design screenshot for the Loopstudios landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I defined a hover-underline-effect mixin to add an underline animation on hover for links

     @mixin hover-underline-effect {
         &::after {
           content: "";
           position: relative;
           display: inline-block;
           width: 100%;
           height: 2px;
           background-color: $White;
           transform: scale(0);
           transition: transform 0.3s ease-in-out;
           transform-origin: right;
           top: -12px;
         }
       
         &:hover {
           &::after {
             transform: scale(1);
             transform-origin: left;
           }
         }
     }

What challenges did you encounter, and how did you overcome them?

Ensuring that the correct image sizes were displayed based on the device screen size

     @HostListener('window:resize', ['$event'])
     onResize(event: any) {
       this.isMobile = window.innerWidth < 768;
     }

     ngOnInit(): void {
       this.isMobile = window.innerWidth < 768;
     }

     getImgSrc(creations: any): string {
       return this.isMobile
         ? creations.imgSrcMobile
         : creations.imgSrcDesktop;
     }

What specific areas of your project would you like help with?

I would appreciate feedback on how to improve the accessibility of my project

Community feedback

@edwinc73

Posted

Impressive work! For accessiblity consider changing the gray text to something darker as the contrast is quite low.

The website breaks on tablet* view, you could add some more media queries to fix this.

Within the nav you could add role="menubar" and role="menuItem"roles to the ul and li items respectively.

You can add aria-labels to the button so screen readers can read it.

edit: fixed spelling table* view

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord