Design comparison
SolutionDesign
Solution retrospective
Hello, I would like to have feedback regarding the structure of the scss file and the management of media queries, regarding the hover effect and good practices please. Thank you.
Community feedback
- @luwa-starPosted almost 4 years ago
Great job JAnneSo! I have a few observations:
- First, you did not in indicate your
<nav>
in the header, it doesn't allow to browsers and other coders to recognise it as a nav bar except for the visual representation. - You should increase your
font-size
for the nav bar as it is small compared to other components in the<header>
section. - Your class names are not descriptive enough. Descriptive class names help your code-readbility.
- There is white space in your landing page in between the sections. Fixing your
margin
orpadding
property should fix that. - The hover effect on your Creations section is quite sharp you should consider in creasing it to probably
opacity:0.8
oropacity:0.7
to ease the effect on the eyes. - Your
<header>
section completely disappears when the screen size is reduced. You should fix that. Moving on to your source code: - There's no need to create two CSS folders. Its increasing the size of your site, just put it in all in one folder.
- According to css semantics, there shouldn't be anything after the
<footer>
tag. It's either you put your contact in the<footer>
tag or you remove it. While it's not showing on your landing page it doesn't look so good on your source code that should be rectified. Overall, you did a great job, keep coding!
0@JAnneSoPosted almost 4 years agoThank you very much for all these points ! It is very important for me to get feedback as relevant as yours to improve my skills.
0 - First, you did not in indicate your
- @aseerktPosted almost 4 years ago
I tried the website. But you forgot to maintain the content width of hero-section and top navabar.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord