Loopstudios landing page main

Community feedback

• 

  Marzuk Sanni•1,360

  @ZukizukPosted 10 months ago

  Hello @Daniela

  Your solution looks great!

  I have few suggestions that might be of help to you:

  1. Consider resetting the margins and paddings at the top of your css file and also consider using border box. Let me demo for you

  * {
     margin: 0;
     padding: 0;
     box-sizing: border-box;
  }
  

  With this you can remove the margins and padding that the browsers set on all the element so as to make it much easier for your desired styling to take effect perfectly.

  Also consider using semantic html for your codes like <header></header> tag for the header <main></main> tags for the main and footer for the footer. Please consider doing this as it's helps in accessibility and also the best way to write html. You might want to use div tags when there's no html tag for it or when necessary.

  Again avoid using this max-width: 1440px; and instead use max-width: 100vw; as the website might look weird when it's opened on a much larger screen. Consider incorporating viewport units like vh vw and the like. You can check more about it here link

  Also, Your main-text container is overflowing horizontally. Usually I would suggest using overflow-x: hidden on the main-text parent or something to prevent the overflow but i think it will hide some content from the viewport so i suggest using viewport unit and making sure it is positioned where it wont cause overflow and check the size you set for the element you position. I will also suggest using rem and em instead of pixels. You can check my solution /my-solution and analyze it.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0

  ---

  

  Daniela Bazán•160

  @danielaebazanPosted 9 months ago

  @Zukizuk Thank you for your feedback, It does help:) I'll keep them in mind.

  0