Design comparison
SolutionDesign
Solution retrospective
Good day everyone, please I want you all to review my work so as to improve on your feedback. Thanks! And Happy coding.
Community feedback
- @tedikoPosted over 3 years ago
Hello, sylvamadu! 👋
Congrats on finishing another challenge! Here are few suggestions from me:
- Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
- Add
:focus
pseudo class to interactive elements like anchors, buttons etc. Useoutline
property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default:focus
pseudo class withoutline
property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles. - Wrap your every section like
.header
,.mid-section
etc and set amax-width
on the container and center it horizontally so the content of the page doesn't look too stretched on large screens.
Good luck with that, have fun coding! 💪
1 - @sylvamaduPosted over 3 years ago
Wow, many thanks for your feedback, I will work on this very soon. Thanks and happy coding.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord