loopstudios

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hi, Basma! 👋

  Nice effort on this challenge! 👏

  A few things I'd like to suggest are,

  • Turning the navigation links in the header and footer of the page into actual links by wrapping each of those elements in a link tag.
  • Turning each of the cards in the "Our Creations" section into links, too (since the hover state shown in the design JPGs implies that they would be links, as well).
  • Allowing the header and footer sections to fill up the entire width of the page in the desktop layout so that there's no empty space to the sides of them on extra-large desktop screens.
  • Making sure to use only h1 tag on your page (since there should only be one most important, main heading per page). Use less important heading tags (such as h2, h3, etc.) for all other headings.
  • Adding some more descriptive alt text for the images in this challenge (since that text will be read by screen readers) or simply leaving the alt text blank if those images are not important to the content of the page and can safely be ignored by screen readers.

  Hope you find this helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  1

  ---

  

  Basma•300

  @btebePosted over 2 years ago

  @ApplePieGiraffe thank you for the feedback:)

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  @btebe

  You're welcome! 😊

  0